qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] virtio-net: allow increasing rx queue size


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH v2] virtio-net: allow increasing rx queue size
Date: Fri, 12 Aug 2016 09:56:17 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0



On 2016年08月11日 19:48, Cornelia Huck wrote:
On Wed, 10 Aug 2016 17:47:16 +0300
"Michael S. Tsirkin" <address@hidden> wrote:

This allows increasing the rx queue size up to 1024: unlike with tx,
guests don't put in huge S/G lists into RX so the risk of running into
the max 1024 limitation due to some off-by-one seems small.

It's helpful for users like OVS-DPDK which don't do any buffering on the
host - 1K roughly matches 500 entries in tun + 256 in the current rx
queue, which seems to work reasonably well. We could probably make do
with ~750 entries but virtio spec limits us to powers of two.
It might be a good idea to specify an s/g size limit in a future
version.

It also might be possible to make the queue size smaller down the road, 64
seems like the minimal value which will still work (as guests seem to
assume a queue full of 1.5K buffers is enough to process the largest
incoming packet, which is ~64K).  No one actually asked for this, and
with virtio 1 guests can reduce ring size without need for host
configuration, so don't bother with this for now.

Cc: Cornelia Huck <address@hidden>
Cc: Jason Wang <address@hidden>
Suggested-by: Patrik Hermansson <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---

changes from v1:
     add macros as suggested by Cornelia

  include/hw/virtio/virtio-net.h |  1 +
  hw/net/virtio-net.c            | 26 +++++++++++++++++++++++++-
  2 files changed, 26 insertions(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <address@hidden>




Queued in net-next (for 2.8)

Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]