Re: [Qemu-devel] [PATCH v1 01/10] target-ppc: add xxspltib instruction

[Nikunj A Dadhania]

Richard Henderson <address@hidden> writes:

> On 08/10/2016 08:00 PM, Nikunj A Dadhania wrote:
>> +#if defined(TARGET_PPC64)
>> +#define pattern(x) (((x) & 0xff) * (~(target_ulong)0 / 0xff))
>> +
>> +static void gen_xxspltib(DisasContext *ctx)
> ...
>> +    tcg_gen_movi_i64(cpu_vsrh(xT(ctx->opcode)), pattern(uim8));
>
> Is this function really not available in 32-bit mode?

I need to on this.

> I'd been pointing out that you should change target_ulong in PATTERN, above, 
> to 
> uint64_t, so that you match tcg_gen_movi_i64.

Ah.. in fact, I had changed it this way first, then thought that this
may not be available in 32-bit and then put it under TARGET_PPC64

Regards
Nikunj