Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

[Igor Mammedov]

On Fri, 12 Aug 2016 09:35:12 +0100
Stefan Hajnoczi <address@hidden> wrote:

> On Fri, Aug 12, 2016 at 02:54:02PM +0800, Xiao Guangrong wrote:
> > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing
> > rx queue siz) on pci branch of Michael's git tree and can be found at:
> >       https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2
> > 
> > Changelog in v2:
> >    Fixed signed integer overflow pointed out by Stefan Hajnoczi
> > 
> > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug,
> > for example, a new nvdimm device can be plugged as follows:
> > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3
> > device_add nvdimm,id=nvdimm3,memdev=mem3
> > 
> > and unplug it as follows:
> > device_del nvdimm3
> > object_del mem3
> > 
> > Xiao Guangrong (8):
> >   acpi nvdimm: fix wrong buffer size returned by DSM method
> >   nvdimm acpi: prebuild nvdimm devices for available slots
> >   nvdimm acpi: introduce _FIT
> >   nvdimm acpi: implement Read FIT function
> >   pc-dimm: introduce prepare_unplug() callback
> >   pc: memhp: do not export nvdimm's memory via _CRS
> >   pc: acpi: memhp: nvdimm hotplug support
> >   nvdimm docs: add nvdimm Read FIT function
> > 
> >  docs/specs/acpi_mem_hotplug.txt  |   4 +-
> >  docs/specs/acpi_nvdimm.txt       |  38 +++++++-
> >  hw/acpi/ich9.c                   |   3 +
> >  hw/acpi/memory_hotplug.c         |  21 +++--
> >  hw/acpi/nvdimm.c                 | 195 
> > +++++++++++++++++++++++++++++++++++----
> >  hw/acpi/piix4.c                  |   3 +
> >  hw/i386/acpi-build.c             |  28 +++++-
> >  hw/mem/nvdimm.c                  |  12 ++-
> >  hw/mem/pc-dimm.c                 |   5 +
> >  include/hw/acpi/memory_hotplug.h |   1 +
> >  include/hw/acpi/pc-hotplug.h     |   1 +
> >  include/hw/mem/nvdimm.h          |   6 +-
> >  include/hw/mem/pc-dimm.h         |   1 +
> >  13 files changed, 278 insertions(+), 40 deletions(-)
> > 
> > -- 
> > 1.8.3.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to address@hidden
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html  
> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>
I'd like to review it but I need to read NVDIMM/ACPI specs first
to make sensible comments.

However it will take some time and I'm on vacation starting next week
and I'll be back in a month. So please don't apply this series until
I'm back and have a chance to review it.