[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [V1 3/4] hw/acpi: report IOAPIC on IVRS
From: |
David Kiarie |
Subject: |
Re: [Qemu-devel] [V1 3/4] hw/acpi: report IOAPIC on IVRS |
Date: |
Fri, 12 Aug 2016 23:23:31 +0300 |
On Fri, Aug 12, 2016 at 11:14 PM, Valentine Sinitsyn <
address@hidden> wrote:
> On 11.08.2016 00:42, David Kiarie wrote:
>
>> Report IOAPIC via IVRS which effectively allows linux AMD-Vi
>> driver to enable interrupt remapping
>>
>> Signed-off-by: David Kiarie <address@hidden>
>> ---
>> hw/i386/acpi-build.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
>> index 49bd183..da602c3 100644
>> --- a/hw/i386/acpi-build.c
>> +++ b/hw/i386/acpi-build.c
>> @@ -2615,6 +2615,8 @@ build_amd_iommu(GArray *table_data, BIOSLinker
>> *linker)
>> * Refer to Spec - Table 95:IVHD Device Entry Type Codes(4-byte)
>> */
>> build_append_int_noprefix(table_data, 0x0000001, 4);
>> + /* IOAPIC represented as an 8-byte entry. Spec v2.62 Tables 97 */
>> + build_append_int_noprefix(table_data, 0x0100a000ff000048, 8);
>>
> Nit: bit 3 in DTE Setting is reserved (Table 97 in the spec), while you
> set them all with 0xff.
Noted, thanks!
>
>
>
>> build_header(linker, table_data, (void *)(table_data->data +
>> iommu_start),
>> "IVRS", table_data->len - iommu_start, 1, NULL, NULL);
>>
>>
> Valentine
>
>
- [Qemu-devel] [V1 0/4] AMD-Vi Interrupt Remapping, David Kiarie, 2016/08/10
- [Qemu-devel] [V1 1/4] hw/iommu: Prepare for AMD IOMMU interrupt remapping, David Kiarie, 2016/08/10
- [Qemu-devel] [V1 2/4] hw/iommu: AMD IOMMU interrupt remapping, David Kiarie, 2016/08/10
- [Qemu-devel] [V1 3/4] hw/acpi: report IOAPIC on IVRS, David Kiarie, 2016/08/10
- [Qemu-devel] [V1 4/4] hw/iommu: share common between IOMMUs, David Kiarie, 2016/08/10
- Re: [Qemu-devel] [V1 0/4] AMD-Vi Interrupt Remapping, David Kiarie, 2016/08/10
- Re: [Qemu-devel] [V1 0/4] AMD-Vi Interrupt Remapping, Valentine Sinitsyn, 2016/08/11