[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime op
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime options |
Date: |
Mon, 15 Aug 2016 11:59:14 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 12.08.2016 um 19:15 hat Max Reitz geschrieben:
> The SSH and NBD block drivers currently directly extract their runtime
> options from the options QDict they receive. This is bad practice and
> can lead to segmentation faults (which, however, will always be a NULL
> pointer dereference, so it should not be exploitable beyond a DoS).
>
> This series fixes that by using QemuOpts instead (like all the other
> block drivers do).
>
> With this series applied, there are only two instances of "qdict_get"
> left in block/, both of which appear to be safe.
Patches 2-5:
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime options, Max Reitz, 2016/08/12
- [Qemu-devel] [PATCH for-2.7? 1/5] block/ssh: Use QemuOpts for runtime options, Max Reitz, 2016/08/12
- [Qemu-devel] [PATCH for-2.7? 3/5] block/blkdebug: Store config filename, Max Reitz, 2016/08/12
- [Qemu-devel] [PATCH for-2.7? 4/5] block/nbd: Store runtime option values, Max Reitz, 2016/08/12
- [Qemu-devel] [PATCH for-2.7? 5/5] iotests: Test case for wrong runtime option types, Max Reitz, 2016/08/12
- [Qemu-devel] [PATCH for-2.7? 2/5] block/nbd: Use QemuOpts for runtime options, Max Reitz, 2016/08/12
- Re: [Qemu-devel] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime options,
Kevin Wolf <=