[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V1 1/1] arm64: Add an option to turn on/off host
|
From: |
Andrea Bolognani |
|
Subject: |
Re: [Qemu-devel] [PATCH V1 1/1] arm64: Add an option to turn on/off host-backed vPMU support |
|
Date: |
Mon, 15 Aug 2016 18:59:34 +0200 |
On Mon, 2016-08-15 at 12:09 +0200, Andrew Jones wrote:
> Hmm... so now if the user doesn't specify pmu=on (off by default) then we
> silently disable it (I think that's a 2.6 compat issue), and if they do
> specify pmu=on, but KVM doesn't support it, then it's silently disabled,
> which isn't nice. I think QEMU should error out in that case, explaining
> that the user specified incompatible options, i.e. they selected accel=kvm
> and pmu=on, but their KVM version (or cpu model) doesn't support PMU
> emulation.
I agree. Asking qemu to provide a feature that it can't provide
should definitely result in a big fat error.
--
Andrea Bolognani / Red Hat / Virtualization