qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build wi


From: Brad Smith
Subject: Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation
Date: Mon, 15 Aug 2016 14:52:33 -0400
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 8/15/2016 1:26 PM, Peter Maydell wrote:

On 8 August 2016 at 17:11, Peter Maydell <address@hidden> wrote:
The various host OSes are irritatingly variable about the name
of the linker emulation we need to pass to ld's -m option to
build the i386 option ROMs. Instead of doing this via a
CONFIG ifdef, check in configure whether any of the emulation
names we know about will work and pass the right answer through
to the makefile. If we can't find one, we fall back to not trying
to build the option ROMs, in the same way we would for a non-x86
host platform.

This is in particular necessary to unbreak the build on OpenBSD,
since it wants a different answer to FreeBSD and we don't have
an existing CONFIG_ variable that distinguishes the two.

Signed-off-by: Peter Maydell <address@hidden>
---
This works for Linux and for the Windows builds; I don't have any
BSD systems to test it on. Brad and Sean, can I ask you to test this
on OpenBSD and FreeBSD, please?

(I think this is going to miss -rc2. Sorry about that; we'll
get OpenBSD builds fixed for -rc3.)
Applied to master (as-is, in the absence of a build check for
i386 OpenBSD; we can always add the elf_i386_obsd entry to the
list as a later patch, and if not then i386 is no worse off
than other non-x86-64 OpenBSD hosts: it just won't build the
option roms from source).

thanks
-- PMM
I am fine with that. Thank you.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]