Re: [Qemu-devel] [PATCH] Revert "vhost-user: Attempt to fix a race with set_mem_table."

[Michael S. Tsirkin]

On Mon, Aug 15, 2016 at 04:15:08PM +0100, Peter Maydell wrote:
> On 15 August 2016 at 14:35, Michael S. Tsirkin <address@hidden> wrote:
> > This reverts commit 28ed5ef16384f12500abd3647973ee21b03cbe23.
> >
> > I still think it's the right thing to do, but
> > tests have been failing sporadically.
> >
> > Revert for now, and hope to fix it before the release.
> >
> > Cc: Prerna Saxena <address@hidden>
> > Cc: Peter Maydell <address@hidden>
> > Cc: Marc-André Lureau <address@hidden>
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > ---
> 
> Applied, thanks. I found my clang-on-x86-64 Linux Ubuntu xenial
> build would hang in vhost-user/read-guest-mem after 10 or
> so iterations, but with this revert applied it seems fine,
> so I think this commit was definitely the culprit.
> 
> -- PMM

That's nice for the RC, but I think we do want to
have the underlying issue fixed down the road.
Prerna, Marc André - any chance you could try
reproducing on an ubuntu guest?

In particular to make sure the issue whatever it is
will not tigger once clients negotiate the
new feature bit.

-- 
MST