Re: [Qemu-devel] [PATCH v4] docs: add cpu-hotplug.txt

[Dou Liyang]

Hi Bharata,

At 08/16/2016 11:31 AM, Bharata B Rao wrote:
> On Tue, Aug 16, 2016 at 11:07:41AM +0800, Dou Liyang wrote:
> > This document describes how to use cpu hotplug in QEMU.
> >
> > Signed-off-by: Andrew Jones <address@hidden>
> > Signed-off-by: Dou Liyang <address@hidden>
> > ---
> > Change log v3 -> v4
> >   From David's advice
> >     1. add spapr examples
> >     2. Fix some comment
> >   From drew's advice
> >     1. Fix some syntax
> > +
> > +For example, the following command-line:
> > +
> > + qemu [...] -smp 3,maxcpus=8,sockets=2,cores=2,threads=2
>
> This is not a valid topology on sPAPR. In the documentation, why not have
> a bit more generic topology that is likely to work for most archs ?
>
> Like -smp 4,maxcpus=8,sockets=2,cores=2,threads=2.

Yes, I got it.
I will change it and check other examples.

Thanks,
Dou