Re: [Qemu-devel] something broken in "v2.7.0-rc1" or just a behavior change?

[Marc-André Lureau]

Hi

On Tue, Aug 16, 2016 at 10:35 AM Dennis Luehring <address@hidden> wrote:

> working: "v2.7.0-rc0" 2d2e632ad00d11867c6c5625605b1fbc022dd62f
> non-working: "v2.7.0-rc1" 69d490079f82f5ffe31fff426aaa580d5fec5fb7
>
> using git bisect i've found this commit:
>
> d7a04fd7d500870ad70f15089c6590e4bea73e70 is the first bad commit
> commit d7a04fd7d500870ad70f15089c6590e4bea73e70
> Author: Marc-André Lureau <address@hidden>
> Date:   Wed Jul 27 01:15:18 2016 +0400
>
>      char: add and use tcp_chr_wait_connected
>
>      Add a chr_wait_connected for the tcp backend, and use it in the
>      open_socket() function.
>
>      Signed-off-by: Marc-André Lureau <address@hidden>
>      Reviewed-by: Michael S. Tsirkin <address@hidden>
>      Signed-off-by: Michael S. Tsirkin <address@hidden>
>
> :100644 100644 6eba615818b7ae96256017663acde90e0e674d30
> a50b8fb3a39c8c5456c901dc420d1fb2aadd1b0d M    qemu-char.c
>
>
I can reproduce, I am looking at it. Thanks for the report


> Am 12.08.2016 um 11:03 schrieb Stefan Hajnoczi:
> > On Fri, Aug 05, 2016 at 07:15:06AM +0200, Dennis Luehring wrote:
> > > my scenario works with before "v2.7.0-rc1"
> > > git "v2.5.0" OK
> > > git "v2.6.0" OK
> > > git "v2.7.0-rc0" OK
> > > git "v2.7.0-rc1" FAILS
> >
> > I suggest using git-bisect(1) to find which commit between v2.7.0-rc0
> > and -rc1 introduced this.  Then you can CC the author of that patch.
> >
> > http://webchick.net/node/99
> > https://git-scm.com/docs/git-bisect
> >
> > Stefan
> >
> > > [qemu-git]
> > > build qemu from git at ~2016/08/04
> > >
> > > git rev-parse HEAD
> > > 09704e6ded83fa0bec14baf32f800f6512156ca0
> > >
> > > [scenario]
> > >
> > > qemu/sparc64-softmmu/qemu-system-sparc64 --version
> > > QEMU emulator version 2.6.91 (v2.7.0-rc1-46-g09704e6-dirty), Copyright
> (c)
> > > 2003-2008 Fabrice Bellard
> > >
> > > if i start qemu with (the other platforms are equaly started)
> > >
> > > qemu/sparc64-softmmu/qemu-system-sparc64 -m 1GB -nographic -monitor
> > > telnet::4440,server,nowait -serial telnet::3000,server -kernel
> > > clfskernel-4.5.0 -initrd big_initrd.cpio
> > >
> > > qemu prints at first:
> > > QEMU waiting for connection on: disconnected:telnet::3000,server
> > >
> > > then i open up a second console and start:
> > > telnet localhost 3000
> > > qemu prints
> > > Trying 127.0.0.1...
> > > Connected to localhost.
> > >
> > > on the console where i started qemu it prints another (v2.7.0-rc0 does
> not
> > > print this line again):
> > > QEMU waiting for connection on: disconnected:telnet::3000,server
> > >
> > > and thats it - nothing more
> > >
> > > same happens for mips64-softmmu/qemu-system-mips64,
> > > ppc64-softmmu/qemu-system-ppc64 and alpha-softmmu/qemu-system-alpha
> > > something broken or a behavior change?
> > >
> > >
> > >
>
>
>
> --
Marc-André Lureau