Re: [Qemu-devel] [PATCH v10 00/11] Provide a QOM-based authorization API

[Daniel P. Berrange]

On Tue, Aug 16, 2016 at 09:21:40AM +0800, Fam Zheng wrote:
> On Mon, 08/15 07:46, address@hidden wrote:
> > /tmp/qemu-test/src/util/authz-pam.c:26:32: warning: security/pam_appl.h: No 
> > such file or directory
> 
> Hi Daniel,
> 
> I think there is an unfortunate CONFIG_ var collision you probably want to
> avoid:
> 
>     $ git grep CONFIG_PAM
>     configure:    echo "CONFIG_PAM=y" >> $config_host_mak
>     default-configs/i386-softmmu.mak:CONFIG_PAM=y
>     default-configs/x86_64-softmmu.mak:CONFIG_PAM=y

Fun, those don't appear to have been used anywhere. In fact I see 4 config
options in default-configs are appear unused

 $ for i in `grep -h -E '^CONFIG' default-configs/*  | sed -e 's/=.*//' | sort 
| uniq`
 do
     echo -n "$i: "
     git grep $i | grep -v default-configs | wc -l
 done | grep  ": 0"
 CONFIG_IPMI_EXTERN: 0
 CONFIG_ISA_MMIO: 0
 CONFIG_PAM: 0
 CONFIG_PIIX_PCI: 0

so I'll send a patch to delete those

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|