Re: [Qemu-devel] [RFC PATCH v2 0/2] Live migration optimization for Thunderx platform

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH v2 0/2] Live migration optimization for 
Thunderx platform
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
58a4317 utils: Add prefetch for Thunderx platform
5898005 utils: Add helper to read arm MIDR_EL1 register

=== OUTPUT BEGIN ===
Checking PATCH 1/2: utils: Add helper to read arm MIDR_EL1 register...
ERROR: space prohibited between function name and open parenthesis '('
#24: FILE: include/qemu/aarch64-cpuid.h:4:
+#if defined (__aarch64__)

ERROR: architecture specific defines should be avoided
#24: FILE: include/qemu/aarch64-cpuid.h:4:
+#if defined (__aarch64__)

ERROR: space prohibited between function name and open parenthesis '('
#62: FILE: util/aarch64-cpuid.c:18:
+#if defined (__aarch64__)

ERROR: architecture specific defines should be avoided
#62: FILE: util/aarch64-cpuid.c:18:
+#if defined (__aarch64__)

WARNING: line over 80 characters
#86: FILE: util/aarch64-cpuid.c:42:
+    const char *file = 
"/sys/devices/system/cpu/cpu0/regs/identification/midr_el1";

total: 4 errors, 1 warnings, 107 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: utils: Add prefetch for Thunderx platform...
ERROR: architecture specific defines should be avoided
#109: FILE: util/cutils.c:208:
+#if defined(__aarch64__)

ERROR: architecture specific defines should be avoided
#122: FILE: util/cutils.c:221:
+#if defined(__aarch64__)

total: 2 errors, 0 warnings, 57 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden