Re: [Qemu-devel] [PATCH for 2.7] ui: fix refresh of VNC server surface

[Daniel P. Berrange]

On Tue, Aug 16, 2016 at 05:21:22PM +0100, Daniel P. Berrange wrote:
> In previous commit
> 
>   commit c7628bff4138ce906a3620d12e0820c1cf6c140d
>   Author: Gerd Hoffmann <address@hidden>
>   Date:   Fri Oct 30 12:10:09 2015 +0100
> 
>     vnc: only alloc server surface with clients connected
> 
> the VNC server was changed so that the 'vd->server' pixman
> image was only allocated when a client is connected.
> 
> Since then if a client disconnects and then reconnects to
> the VNC server all they will see is a black screen until
> they do something that triggers a refresh. On a graphical
> desktop this is not often noticed since there's many things
> going on which cause a refresh. On a plain text console it
> is really obvious since nothing refreshes frequently.
> 
> The problem is that the VNC server didn't update the guest
> dirty bitmap, so still believes its server image is in sync
> with the guest contents.
> 
> To fix this we must explicitly mark the entire guest desktop
> as dirty after re-creating the server surface. Move this
> logic into vnc_update_server_surface() so it is guaranteed
> to be call in all code paths that re-create the surface
> instead of only in vnc_dpy_switch()
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> 
> NB This should go into 2.5 & 2.6 stable branches too
> 
>  ui/vnc.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)

And next time I'll make sure I committed all outstanding
chunks before sending the email :-)

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|