[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/18] migration: fix ram_save_pending
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 02/18] migration: fix ram_save_pending |
Date: |
Wed, 17 Aug 2016 13:12:35 +0100 |
User-agent: |
Mutt/1.6.2 (2016-07-01) |
* Vladimir Sementsov-Ogievskiy (address@hidden) wrote:
> Fill postcopy-able pending only if ram postcopy is enabled.
> It is necessary because of there will be other postcopy-able states and
> when ram postcopy is disabled, it should not spoil common postcopy
> related pending.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/ram.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index fa5c72b..424ce0b 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2079,8 +2079,12 @@ static void ram_save_pending(QEMUFile *f, void
> *opaque, uint64_t max_size,
> remaining_size = ram_save_remaining() * TARGET_PAGE_SIZE;
> }
>
> - /* We can do postcopy, and all the data is postcopiable */
> - *postcopiable_pending += remaining_size;
> + if (migrate_postcopy_ram()) {
> + /* We can do postcopy, and all the data is postcopiable */
> + *postcopiable_pending += remaining_size;
> + } else {
> + *non_postcopiable_pending += remaining_size;
> + }
> }
>
> static int load_xbzrle(QEMUFile *f, ram_addr_t addr, void *host)
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 00/18] Dirty bitmaps postcopy migration, Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 07/18] qapi: add dirty-bitmaps migration capability, Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 02/18] migration: fix ram_save_pending, Vladimir Sementsov-Ogievskiy, 2016/08/16
- Re: [Qemu-devel] [PATCH 02/18] migration: fix ram_save_pending,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 01/18] migration: add has_postcopy savevm handler, Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 11/18] migration: add is_active_iterate handler, Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 18/18] iotests: add dirty bitmap postcopy test, Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 03/18] migration: split common postcopy out of ram postcopy, Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 10/18] migration/qemu-file: add qemu_put_counted_string(), Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 16/18] iotests: add default node-name, Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 06/18] block: add bdrv_dirty_bitmap_enable_successor(), Vladimir Sementsov-Ogievskiy, 2016/08/16
- [Qemu-devel] [PATCH 15/18] qapi: add md5 checksum of last dirty bitmap level to query-block, Vladimir Sementsov-Ogievskiy, 2016/08/16