qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] net/net: Bugfix for net_fill_rstate()


From: Zhang Chen
Subject: Re: [Qemu-devel] [PATCH] net/net: Bugfix for net_fill_rstate()
Date: Thu, 18 Aug 2016 11:13:09 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0



On 08/18/2016 09:31 AM, Li Zhijian wrote:
/*
 * Returns
 * 0: SocketReadState is not ready
 * 1: SocketReadState is ready
 * otherwise error occurs
 */
int net_fill_rstate(SocketReadState *rs, const uint8_t *buf, int size)

it seems you need to fix the returns and comments too.
simply, just remove the 'return 1;' would be OK ?
because the callers only concern about the error case.

OK, I got your point, will fix it in V2.

--
Thanks
zhangchen






reply via email to

[Prev in Thread] Current Thread [Next in Thread]