Re: [Qemu-devel] [PATCH] test-logging: don't hard-code paths in /tmp

[Peter Maydell]

On 15 August 2016 at 19:24, Sascha Silbe <address@hidden> wrote:
> Dear Peter,
>
> Peter Maydell <address@hidden> writes:
>
>> On 15 July 2016 at 17:24, Sascha Silbe <address@hidden> wrote:
> [...]
>>> Instead of hard-coding the paths, create a temporary directory using
>>> g_dir_make_tmp() and clean it up afterwards.
>>>
>>> Fixes: f6880b7f ("qemu-log: support simple pid substitution for logs")
>>> Signed-off-by: Sascha Silbe <address@hidden>
>>
>> Thanks for this patch -- I just noticed that the test was leaving
>> temporary files not cleaned up, which brought me to this patch
>> by searching the mail archives...
>
> I have totally forgotten about it. Would probably have remembered the
> next time "make check" failed on a shared machine. ;)

Are you planning to send a v2 of this patch? I was hoping we could
fix the non-deleted logfiles for qemu 2.7.0 but it's getting a bit
late in the cycle...

thanks
-- PMM