[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility |
Date: |
Thu, 18 Aug 2016 15:22:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 18/08/2016 15:25, Cao jin wrote:
>
>
> On 08/18/2016 09:04 PM, Paolo Bonzini wrote:
>>
>>
>> On 18/08/2016 15:11, Cao jin wrote:
>>>
>>>
>>> On 08/18/2016 06:47 PM, Paolo Bonzini wrote:
>>>>
>>>>
>>>> On 17/08/2016 16:39, Cao jin wrote:
>>>>> commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it
>>>>> is used by intr_state which exists in vmstate. Restore it for
>>>>> migration
>>>>> to older QEMU versions
>>>>>
>>>>> CC: Dmitry Fleytman <address@hidden>
>>>>> CC: Jason Wang <address@hidden>
>>>>> CC: Markus Armbruster <address@hidden>
>>>>> CC: Marcel Apfelbaum <address@hidden>
>>>>> CC: Michael S. Tsirkin <address@hidden>
>>>>> Signed-off-by: Cao jin <address@hidden>
>>>>
>>>> Not necessary. No released version of QEMU had e1000e and lacked
>>>> commit
>>>> 66bf7d58.
>>>>
>>>> Paolo
>>>>
>>>
>>> Ok, then I will make this patch as separated one and send it out asap,
>>> so maybe it goes in 2.7
>>
>> It's not necessary at all; why would it be useful in 2.7?
>>
>> Paolo
>>
>
> commit 66bf7d58I already removed E1000E_USE_MSI, so I think maybe I can
> send a patch to remove E1000E_USE_MSIX & intr_state, so there will be no
> migration compatibility issue
Please do, worst case it won't be accepted.
Paolo
[Qemu-devel] [PATCH 5/6] megasas: remove unnecessary megasas_use_msix(), Cao jin, 2016/08/17
[Qemu-devel] [PATCH 6/6] megasas: undo the overwrites of user configuration, Cao jin, 2016/08/17
[Qemu-devel] [PATCH 1/6] msix_init: assert programming error, Cao jin, 2016/08/17
[Qemu-devel] [PATCH 2/6] pci: Convert msix_init() to Error and fix callers to check it, Cao jin, 2016/08/17