[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag |
Date: |
Thu, 18 Aug 2016 19:37:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> Dmitry Fleytman <address@hidden> writes:
>
>>> On 18 Aug 2016, at 17:15, Cao jin <address@hidden> wrote:
[...]
>>> @@ -601,7 +596,6 @@ static const VMStateDescription e1000e_vmstate = {
>>> VMSTATE_MSIX(parent_obj, E1000EState),
>>>
>>> VMSTATE_UINT32(ioaddr, E1000EState),
>>> - VMSTATE_UINT32(intr_state, E1000EState),
>
> We can still do this, because as Paolo pointed out, no released version
> of QEMU had this device.
Which means we better get this into 2.7.0. Thoughts?
>>> VMSTATE_UINT32(core.rxbuf_min_shift, E1000EState),
>>> VMSTATE_UINT8(core.rx_desc_len, E1000EState),
>>> VMSTATE_UINT32_ARRAY(core.rxbuf_sizes, E1000EState,
>>> --
>>> 2.1.0
>
> Reviewed-by: Markus Armbruster <address@hidden>