Re: [Qemu-devel] [PATCH 0/6] Recovery from network failure during Postcopy Migration

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/6] Recovery from network failure during Postcopy 
Migration
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
f265ac8 Migration: Recovering pages lost due to n/w failure during pc migration 
(destination)
f92ad90 Migration: Recovering pages lost due to n/w failure during pc migration 
(source)
0b2e481 Migration: New bitmap for postcopy migration failure
970a113 Migration: Reconnect network in case of network failure during pc 
migration (destination)
be8f55b migration : General additions for migration recovery
e16354b Migration: Reconnect network in case of network failure during pc 
migration (source)

=== OUTPUT BEGIN ===
Checking PATCH 1/6: Migration: Reconnect network in case of network failure 
during pc migration (source)...
WARNING: line over 80 characters
#86: FILE: include/migration/migration.h:356:
+int qemu_migrate_postcopy_incoming_recovery(QEMUFile 
**f,MigrationIncomingState* mis);

ERROR: space required after that ',' (ctx:VxV)
#86: FILE: include/migration/migration.h:356:
+int qemu_migrate_postcopy_incoming_recovery(QEMUFile 
**f,MigrationIncomingState* mis);
                                                         ^

WARNING: line over 80 characters
#187: FILE: migration/migration.c:1155:
+                /* shutdown the rp socket, so causing the rp thread to 
shutdown */

ERROR: do not use assignment in if condition
#227: FILE: migration/migration.c:1848:
+        if ((ret = qemu_file_get_error(s->to_dst_file))) {

ERROR: space required before the open parenthesis '('
#239: FILE: migration/migration.c:1860:
+                if(ret == 0) {

ERROR: spaces required around that '/' (ctx:VxV)
#287: FILE: migration/migration.c:1967:
+    s->expected_downtime = max_downtime/1000000;
                                        ^

ERROR: "foo* bar" should be "foo *bar"
#300: FILE: migration/migration.c:1980:
+int qemu_migrate_postcopy_outgoing_recovery(MigrationState* ms)

ERROR: space required before the open parenthesis '('
#308: FILE: migration/migration.c:1988:
+    while(atomic_mb_read(&ms->in_recovery) == true) {

WARNING: line over 80 characters
#309: FILE: migration/migration.c:1989:
+        fprintf(stderr, "Under recovery, not letting it fail %p\n", 
ms->to_dst_file);

ERROR: space required before the open parenthesis '('
#314: FILE: migration/migration.c:1994:
+    if(ms->to_dst_file != NULL) {

total: 7 errors, 3 warnings, 371 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/6: migration : General additions for migration recovery...
Checking PATCH 3/6: Migration: Reconnect network in case of network failure 
during pc migration (destination)...
WARNING: line over 80 characters
#108: FILE: migration/migration.c:1081:
+void qmp_migrate_incoming(const char *uri, bool in_recover, bool recover, 
Error **errp)

ERROR: space required before the open parenthesis '('
#123: FILE: migration/migration.c:1091:
+            if(!atomic_mb_read(&mis->in_recovery)) {

ERROR: space required before the open parenthesis '('
#135: FILE: migration/migration.c:1103:
+                if(mis->have_fault_thread) {

ERROR: line over 90 characters
#136: FILE: migration/migration.c:1104:
+                    /* shutdown the socket to source, causing the fault_thread 
to shutdown */

ERROR: suspect code indent for conditional statements (4, 9)
#163: FILE: migration/migration.c:1131:
+    if (!recover && !deferred_incoming) {
+         error_setg(errp, "For use with '-incoming defer'");

ERROR: "foo* bar" should be "foo *bar"
#177: FILE: migration/migration.c:2069:
+                                            MigrationIncomingState* mis)

ERROR: space required before the open parenthesis '('
#185: FILE: migration/migration.c:2077:
+    while(atomic_mb_read(&mis->in_recovery) == true) {

WARNING: line over 80 characters
#186: FILE: migration/migration.c:2078:
+        fprintf(stderr, "Recover, not letting it fail %p\n", 
mis->from_src_file);

ERROR: space required before the open parenthesis '('
#191: FILE: migration/migration.c:2083:
+    if(mis->from_src_file != NULL) {

total: 7 errors, 2 warnings, 286 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: Migration: New bitmap for postcopy migration failure...
ERROR: "foo* bar" should be "foo *bar"
#75: FILE: migration/ram.c:2350:
+        RAMBlock* block = NULL;

ERROR: do not initialise statics to 0 or NULL
#151: FILE: migration/ram.c:2634:
+    static int count = 0;

ERROR: space required before the open parenthesis '('
#153: FILE: migration/ram.c:2636:
+    if(count == 1000) {

total: 3 errors, 0 warnings, 138 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: Migration: Recovering pages lost due to n/w failure during 
pc migration (source)...
Checking PATCH 6/6: Migration: Recovering pages lost due to n/w failure during 
pc migration (destination)...
ERROR: else should follow close brace '}'
#67: FILE: migration/ram.c:2677:
+            }
+            else {

WARNING: line over 80 characters
#105: FILE: migration/savevm.c:1690:
+                       migrate_incoming_ram_req_pages, mis, 
QEMU_THREAD_DETACHED);

total: 1 errors, 1 warnings, 79 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden