[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v4] qemu-img: change opening method
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v4] qemu-img: change opening method for the output in dd |
|
Date: |
Mon, 22 Aug 2016 08:58:31 -0400 |
|
User-agent: |
Mutt/1.6.2 (2016-07-01) |
On Sat, Aug 20, 2016 at 05:52:49PM +0200, Reda Sallahi wrote:
> + blk2 = blk_new_open(image_opts ? NULL : out.filename,
> + NULL, qoptions, BDRV_O_RDWR, NULL);
As mentioned in my reply to the previous version, please reuse
img_open() to avoid duplicating code. You can extend img_open() if
necessary to suppress errors.
signature.asc
Description: PGP signature