[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 5/7] qemu-img: add status option to
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 5/7] qemu-img: add status option to dd |
|
Date: |
Mon, 22 Aug 2016 09:45:02 -0400 |
|
User-agent: |
Mutt/1.6.2 (2016-07-01) |
On Mon, Aug 22, 2016 at 09:55:15AM +0200, Reda Sallahi wrote:
> struct DdInfo {
> unsigned int flags;
> int64_t count;
> unsigned int conv;
> + unsigned status;
For consistency please use "unsigned int" like you used for the flags
and conv fields above.
> in.buf = g_new(uint8_t, in.bsz);
> + if (dd.status & C_STATUS_DEFAULT) {
> + gettimeofday(&starttv, NULL);
Please use qemu_gettimeofday() for portability.
signature.asc
Description: PGP signature