qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavaila


From: Sascha Silbe
Subject: Re: [Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavailable)
Date: Tue, 23 Aug 2016 21:00:19 +0200
User-agent: Notmuch/0.22.1~rc0 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu)

Dear Stefan,

Stefan Weil <address@hidden> writes:

> Commit 50455700092412d90ffaf57ee5d00f38f7d1cc5b added new code which
> does not compile for Windows.
[...]

[include/glib-compat.h]
> @@ -48,6 +48,7 @@ static inline gint64 qemu_g_get_monotonic_time(void)
>  gint g_poll_fixed(GPollFD *fds, guint nfds, gint timeout);
>  #endif
>
> +#if !defined(_WIN32)
>  #if !GLIB_CHECK_VERSION(2, 30, 0)
>  /* Not a 100% compatible implementation, but good enough for most
>   * cases. Placeholders are only supported at the end of the
> @@ -65,8 +66,10 @@ static inline gchar *qemu_g_dir_make_tmp(gchar const 
> *tmpl, GError **error)
>      g_free(path);
>      return NULL;
>  }
> +
>  #define g_dir_make_tmp(tmpl, error) qemu_g_dir_make_tmp(tmpl, error)
>  #endif /* glib 2.30 */
> +#endif /* !_WIN32 */

This worked fine in my cross-build environment (mingw32-* on Fedora 22)
as that has glib 2.44.0. Is there a specific reason you're using a glib
version that's at least half a decade old (glib 2.30.0 was released in
2011) on Windows? AFAICT the MSYS2 installer recommended by glib
upstream [1] has glib 2.41.1.

As for your change: It may fix building qemu itself, but building
test-logging should still be broken. Unlike some other tests, it isn't
built on POSIX or Linux only. Did "make check" work before my patch in
your environment?

Sascha

[1] http://www.gtk.org/download/windows.php
[2] https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-glib2/PKGBUILD
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641




reply via email to

[Prev in Thread] Current Thread [Next in Thread]