[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag |
Date: |
Tue, 23 Aug 2016 23:12:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Amit Shah <address@hidden> writes:
> On (Mon) 22 Aug 2016 [16:09:27], Jason Wang wrote:
>> From: Cao jin <address@hidden>
>>
>> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI,
>> E1000E_USE_MSIX
>> is not necessary too, remove it now. And interrupt flag field intr_state also
>> can be removed now.
>>
>> CC: Dmitry Fleytman <address@hidden>
>> CC: Jason Wang <address@hidden>
>> CC: Markus Armbruster <address@hidden>
>> CC: Marcel Apfelbaum <address@hidden>
>> CC: Michael S. Tsirkin <address@hidden>
>> CC: Paolo Bonzini <address@hidden>
>> Signed-off-by: Cao jin <address@hidden>
>> Reviewed-by: Markus Armbruster <address@hidden>
>> Acked-by: Dmitry Fleytman <address@hidden>
>> Reviewed-by: Paolo Bonzini <address@hidden>
>> Signed-off-by: Jason Wang <address@hidden>
>> ---
>> hw/net/e1000e.c | 8 +-------
>> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>
>> @@ -601,7 +596,6 @@ static const VMStateDescription e1000e_vmstate = {
>> VMSTATE_MSIX(parent_obj, E1000EState),
>>
>> VMSTATE_UINT32(ioaddr, E1000EState),
>> - VMSTATE_UINT32(intr_state, E1000EState),
>> VMSTATE_UINT32(core.rxbuf_min_shift, E1000EState),
>> VMSTATE_UINT8(core.rx_desc_len, E1000EState),
>> VMSTATE_UINT32_ARRAY(core.rxbuf_sizes, E1000EState,
>
> This breaks migration - please mark that field 'unused'.
Does it matter? The device hasn't been in any released version of
QEMU...