Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

[Richard Henderson]

On 08/23/2016 09:38 PM, Paolo Bonzini wrote:
> On 24/08/2016 06:30, address@hidden wrote:
> > ERROR: Use of volatile is usually wrong: see 
> > Documentation/volatile-considered-harmful.txt
> > #44: FILE: util/cutils.c:289:
> > +        __asm volatile("vmovdqu -0x80(%1),%0\n\t"
>
> Other errors can be ignored, but please use __asm__ __volatile__ here or
> just __asm__ (I don't think volatile is useful).

I had to add volatile to keep the prefetch in advance of the loop.
I suppose I could just add the prefetch to the asm block...


> Also, perhaps move this function to its own file since you're rewriting
> it anyway?

Sure.


r~