Re: [Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform

[David Gibson]

On Sat, Aug 27, 2016 at 08:48:10AM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2016-08-26 at 16:47 +0200, Cédric Le Goater wrote:
> > >> +static void powernv_machine_class_init(ObjectClass *oc, void
> > *data)
> > >> +{
> > >> +    MachineClass *mc = MACHINE_CLASS(oc);
> > >> +
> > >> +    mc->init = ppc_powernv_init;
> > >> +    mc->reset = ppc_powernv_reset;
> > >> +    mc->block_default_type = IF_IDE;
> > > 
> > > IDE?  Really?
> > 
> > nah :) It's SCSI again now.
> > 
> > I was trying to reconcile all the little hunks in the different 
> > patches of Ben. IF_IDE was introduced at the end of the patchset. 
> > I suppose that adding a ISA bus to PowerNV had some influence :)
> 
> It's meant to be IF_IDE, the default interface is AHCI.

Ah, right.  A comment mentioning AHCI would help to clarify this.


-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature