Re: [Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavailable)

[Sascha Silbe]

Dear Peter,

Peter Maydell <address@hidden> writes:

> On 25 August 2016 at 10:36, Peter Maydell <address@hidden> wrote:
>> On 23 August 2016 at 16:01, Sascha Silbe <address@hidden> wrote:
>>> Glad to hear. It would be possibly to support the combination of glib <
>>> 2.30.0 AND windows, but only by copying a considerable amount of code
>>> from glib. I'd prefer to avoid that if we can help it.
>>
>> If we want to raise the minimum glib version requirement for
>> Windows we need to enforce this in configure. (We have had
>> a higher minimum for Windows hosts in the past, so there's
>> precedent for doing it.)
>
> Or we could arrange to skip this test if we're on windows
> with an old glib I guess.

In general I agree with you. In practice test-logging was completely
broken on Windows since 2.6.0 (it hard-coded /tmp) and I don't have a
suitable environment to test a Windows build, so I'd feel uncomfortable
submitting patches addressing this issue myself.

However that shouldn't stop anyone else (Stefan perhaps? :) ) from
fixing the tests on Windows. I'll gladly review the effects of the
corresponding patches on the POSIX side.

Sascha
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641