Re: [Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavailable)

[Stefan Weil]

On 08/29/16 17:27, Sascha Silbe wrote:
> Dear Peter,
>
> Peter Maydell <address@hidden> writes:
>
> > On 25 August 2016 at 10:36, Peter Maydell <address@hidden> wrote:
> > > On 23 August 2016 at 16:01, Sascha Silbe <address@hidden> wrote:
> > > > Glad to hear. It would be possibly to support the combination of glib <
> > > > 2.30.0 AND windows, but only by copying a considerable amount of code
> > > > from glib. I'd prefer to avoid that if we can help it.
> > >
> > > If we want to raise the minimum glib version requirement for
> > > Windows we need to enforce this in configure. (We have had
> > > a higher minimum for Windows hosts in the past, so there's
> > > precedent for doing it.)
> >
> > Or we could arrange to skip this test if we're on windows
> > with an old glib I guess.
>
> In general I agree with you. In practice test-logging was completely
> broken on Windows since 2.6.0 (it hard-coded /tmp) and I don't have a
> suitable environment to test a Windows build, so I'd feel uncomfortable
> submitting patches addressing this issue myself.
>
> However that shouldn't stop anyone else (Stefan perhaps? :) ) from
> fixing the tests on Windows. I'll gladly review the effects of the
> corresponding patches on the POSIX side.
>
> Sascha

For 2.7, I think we don't need this patch nor any other solution, 
because the problem is less critical than I thought initially: only 
builds with old versions of glib are affected.

For 2.8, raising the minimum glib version to 2.30.0 would avoid the 
build problem for normal builds targeting Windows. IMHO it is the 
simplest and also an acceptable solution, and it also allows removing 
some conditional code.

Fixing the tests for builds targeting Windows is a different issue. 
Ideally "make test" should work for such builds, no matter whether they 
run as cross build on Linux (my usual environment) or native on Windows. 
To simplify things, some tests which are difficult to fix for Windows 
and which don't test Windows specific code could be omitted. I cannot 
promise that I'll work on test support for Windows in the near future – 
if anybody else does that job, I'll be happy, too.

Stefan