qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36
Date: Tue, 30 Aug 2016 17:35:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0


On 30/08/2016 14:44, Markus Armbruster wrote:
>> > There is no limit in the SCSI spec.  20 was copy-pasted from virtio-blk
>> > which in turn was copy-pasted from ATA.  So 36 is even more arbitrary,
>> > but bumping it up too much might cause issues (e.g. who knows there's no
>> > off-by-one somewhere if I make it 252, so that 256 is the maximum amount
>> > of returned data).
> This paragraph would make a nice addition to the commit message :)

Will do!

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]