[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.8 06/11] intel_iommu: support device iotlb
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH for 2.8 06/11] intel_iommu: support device iotlb descriptor |
Date: |
Thu, 1 Sep 2016 09:26:00 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Aug 31, 2016 at 10:54:36AM +0800, Jason Wang wrote:
> >> static void x86_iommu_instance_init(Object *o)
> >> {
> >> X86IOMMUState *s = X86_IOMMU_DEVICE(o);
> >>@@ -108,6 +120,11 @@ static void x86_iommu_instance_init(Object *o)
> >> s->intr_supported = false;
> >> object_property_add_bool(o, "intremap", x86_iommu_intremap_prop_get,
> >> x86_iommu_intremap_prop_set, NULL);
> >>+ s->dt_supported = false;
> >>+ object_property_add_bool(o, "device_iotlb",
> >>+ x86_iommu_device_iotlb_prop_get,
> >>+ x86_iommu_device_iotlb_prop_set,
> >>+ NULL);
> >Nit 1: use "device-iotlb" instead of "device_iotlb"?
>
> Yes.
>
> >Nit 2: use Property bit (like vtd_properties)?
>
> Not sure, I thought this may be reused by AMD IOMMU but maybe I was wrong.
I mean to create another Property for x86-iommus. :)
Anyway both work for me, and actually "intremap" property is doing it
that way as well...
-- peterx
[Qemu-devel] [PATCH for 2.8 04/11] intel_iommu: allocate new key when creating new address space, Jason Wang, 2016/08/29
[Qemu-devel] [PATCH for 2.8 05/11] exec: introduce address_space_get_iotlb_entry(), Jason Wang, 2016/08/29
[Qemu-devel] [PATCH for 2.8 06/11] intel_iommu: support device iotlb descriptor, Jason Wang, 2016/08/29
[Qemu-devel] [PATCH for 2.8 07/11] virtio-pci: address space translation service (ATS) support, Jason Wang, 2016/08/29
[Qemu-devel] [PATCH for 2.8 09/11] memory: handle alias for iommu notifier, Jason Wang, 2016/08/29
[Qemu-devel] [PATCH for 2.8 08/11] acpi: add ATSR for q35, Jason Wang, 2016/08/29
[Qemu-devel] [PATCH for 2.8 10/11] Revert "intel_iommu: Throw hw_error on notify_started", Jason Wang, 2016/08/29