Re: [Qemu-devel] [PATCH] i8257: Make device "i8257" unavailable with -device

[Paolo Bonzini]

On 31/08/2016 18:15, Markus Armbruster wrote:
> The ISA DMA controller needs to be wired up to the ISA bus by
> isa_bus_dma() to actually work.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  hw/dma/i8257.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
> index f345c54..f90df1d 100644
> --- a/hw/dma/i8257.c
> +++ b/hw/dma/i8257.c
> @@ -598,6 +598,8 @@ static void i8257_class_init(ObjectClass *klass, void 
> *data)
>      idc->release_DREQ = i8257_dma_release_DREQ;
>      idc->schedule = i8257_dma_schedule;
>      idc->register_channel = i8257_dma_register_channel;
> +    /* Reason: needs to be wired up by isa_bus_dma() to work */
> +    dc->cannot_instantiate_with_device_add_yet = true;
>  }
>  
>  static const TypeInfo i8257_info = {
> 

Queued for 2.8, thanks.

Paolo