[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] tests: Fix broken tcg test compilation
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] tests: Fix broken tcg test compilation |
Date: |
Fri, 2 Sep 2016 12:56:45 +0100 |
On 2 September 2016 at 12:49, Michal Privoznik <address@hidden> wrote:
> The first build error to be seen is that linux-test.c fails to
> include cutils.h:
>
> linux-test.c:42:25: fatal error: qemu/cutils.h: No such file or directory
>
> This is because toplevel include/ dir is not put onto compiler's
> command line. After that:
>
> qemu.git/include/qemu/cutils.h:171:1: error: unknown type name ‘bool’
>
> So we need to include "qemu/osdep.h" which will define bool type
> for us. However, osdep.h eventually includes glib.h from system,
> therefore we need to put GLIB_CFLAGS onto compiler's command line
> too.
Why are we including qemu/cutils.h anyway? As far as I can see
we don't use it for anything and removing the #include doesn't
cause any problems...
thanks
-- PMM