Re: [Qemu-devel] [PATCH v3 0/2] Add a test for serial output (and sort tests by architecture in the Makefile)

[David Gibson]

On Sat, Sep 03, 2016 at 11:57:49AM +0200, Thomas Huth wrote:
> Since some of the machines that we support in QEMU sometimes get
> broken by other changes, and it then takes a while 'till somebody
> notices the breakage, it would be nice to get some more automatic
> test coverage for various machines during "make check". The
> second patch adds such a test for the machines where we've got
> a firmware image for and thus can test for some magic strings
> in the serial output of the firmware.
> 
> The first patch is just a clean-up for the Makefile to avoid that
> new tests get added with "=" instead of "+=" (and thus completely
> overwrite the correspond variable by accident).

Applied to ppc-for-2.8, thanks.

> 
> v3:
> - Rebased to master (there were some conflicts in Makefile.include)
> 
> v2:
> - Some more clean-ups for the Makefile (i.e. some additional empty
>   lines)
> - Check return value of read() to make sure that there is no error
> 
> Thomas Huth (2):
>   tests: Resort check-qtest entries in Makefile.include
>   tests: Check serial output of firmware boot of some machines
> 
>  tests/Makefile.include   |  52 +++++++++++++++-------
>  tests/boot-serial-test.c | 110 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 146 insertions(+), 16 deletions(-)
>  create mode 100644 tests/boot-serial-test.c
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature