Re: [Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
e6702f3 MAINTAINERS: add maintainer for COLO-proxy
f18685f filter-rewriter: rewrite tcp packet to keep secondary connection
890ddae filter-rewriter: track connection and parse packet
4c1b3da filter-rewriter: introduce filter-rewriter initialization
783910b colo-compare: add TCP, UDP, ICMP packet comparison
f40c0ce colo-compare: introduce packet comparison thread
e7f20bb colo-compare: track connection and enqueue packet
74df843 Jhash: add linux kernel jhashtable in qemu
ca61df9 net/colo.c: add colo.c to define and handle packet
259c094 colo-compare: introduce colo compare initialization
c499262 qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext
9788260 docs: Add documentation for COLO-proxy

=== OUTPUT BEGIN ===
Checking PATCH 1/12: docs: Add documentation for COLO-proxy...
Checking PATCH 2/12: qemu-char: Add qemu_chr_add_handlers_full() for 
GMaincontext...
Checking PATCH 3/12: colo-compare: introduce colo compare initialization...
ERROR: suspect code indent for conditional statements (4, 4)
#216: FILE: net/colo-compare.c:120:
+    } else if (strcmp(name, "host") == 0) {
+    } else if (strcmp(name, "port") == 0) {

ERROR: suspect code indent for conditional statements (4, 4)
#217: FILE: net/colo-compare.c:121:
+    } else if (strcmp(name, "port") == 0) {
+    } else if (strcmp(name, "server") == 0) {

ERROR: suspect code indent for conditional statements (4, 4)
#218: FILE: net/colo-compare.c:122:
+    } else if (strcmp(name, "server") == 0) {
+    } else if (strcmp(name, "wait") == 0) {

ERROR: suspect code indent for conditional statements (4, 4)
#219: FILE: net/colo-compare.c:123:
+    } else if (strcmp(name, "wait") == 0) {
+    } else if (strcmp(name, "path") == 0) {

ERROR: suspect code indent for conditional statements (4, 4)
#220: FILE: net/colo-compare.c:124:
+    } else if (strcmp(name, "path") == 0) {
+    }else {

ERROR: space required after that close brace '}'
#221: FILE: net/colo-compare.c:125:
+    }else {

ERROR: space required after that ',' (ctx:VxV)
#280: FILE: net/colo-compare.c:184:
+    if(find_and_check_chardev(&s->chr_pri_in, s->pri_indev,errp)) {
                                                           ^

ERROR: space required before the open parenthesis '('
#280: FILE: net/colo-compare.c:184:
+    if(find_and_check_chardev(&s->chr_pri_in, s->pri_indev,errp)) {

ERROR: space required after that ',' (ctx:VxV)
#284: FILE: net/colo-compare.c:188:
+    if(find_and_check_chardev(&s->chr_sec_in, s->sec_indev,errp)) {
                                                           ^

ERROR: space required before the open parenthesis '('
#284: FILE: net/colo-compare.c:188:
+    if(find_and_check_chardev(&s->chr_sec_in, s->sec_indev,errp)) {

ERROR: space required after that ',' (ctx:VxV)
#288: FILE: net/colo-compare.c:192:
+    if(find_and_check_chardev(&s->chr_out, s->outdev,errp)) {
                                                     ^

ERROR: space required before the open parenthesis '('
#288: FILE: net/colo-compare.c:192:
+    if(find_and_check_chardev(&s->chr_out, s->outdev,errp)) {

total: 12 errors, 0 warnings, 326 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/12: net/colo.c: add colo.c to define and handle packet...
Checking PATCH 5/12: Jhash: add linux kernel jhashtable in qemu...
Checking PATCH 6/12: colo-compare: track connection and enqueue packet...
WARNING: line over 80 characters
#248: FILE: net/colo.c:180:
+            trace_colo_proxy_main("colo proxy connection hashtable full, clear 
it");

total: 0 errors, 1 warnings, 241 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/12: colo-compare: introduce packet comparison thread...
Checking PATCH 8/12: colo-compare: add TCP, UDP, ICMP packet comparison...
Checking PATCH 9/12: filter-rewriter: introduce filter-rewriter 
initialization...
Checking PATCH 10/12: filter-rewriter: track connection and parse packet...
Checking PATCH 11/12: filter-rewriter: rewrite tcp packet to keep secondary 
connection...
Checking PATCH 12/12: MAINTAINERS: add maintainer for COLO-proxy...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden