Re: [Qemu-devel] [PATCH v4 0/5] linux-user: Fix miscellaneous Mips-specific issues

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v4 0/5] linux-user: Fix miscellaneous 
Mips-specific issues
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0db934a linux-user: Fix certain argument alignment cases for Mips64
41c12a1 linux-user: Fix structure target_semid64_ds definition for Mips
60e192a linux-user: Fix structure target_flock definition for Mips
39b0a11 linux-user: Fix TARGET_F_GETOWN definition for Mips
e9823a3 linux-user: Fix TARGET_SIOCATMARK definition for Mips

=== OUTPUT BEGIN ===
Checking PATCH 1/5: linux-user: Fix TARGET_SIOCATMARK definition for Mips...
Checking PATCH 2/5: linux-user: Fix TARGET_F_GETOWN definition for Mips...
Checking PATCH 3/5: linux-user: Fix structure target_flock definition for 
Mips...
Checking PATCH 4/5: linux-user: Fix structure target_semid64_ds definition for 
Mips...
Checking PATCH 5/5: linux-user: Fix certain argument alignment cases for 
Mips64...
ERROR: open brace '{' following function declarations go on the next line
#26: FILE: linux-user/syscall.c:623:
+static inline int regpairs_aligned(void *cpu_env) {

total: 1 errors, 0 warnings, 14 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden