[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/12] cpus-common: always defer async_run_on_cp
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 09/12] cpus-common: always defer async_run_on_cpu work items |
Date: |
Mon, 05 Sep 2016 15:57:42 +0100 |
User-agent: |
mu4e 0.9.17; emacs 25.1.11 |
Paolo Bonzini <address@hidden> writes:
> async_run_on_cpu is only called from the I/O thread, not from CPU threads,
> so it doesn't make any difference. It will make a difference however
> for async_safe_run_on_cpu.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> cpus-common.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/cpus-common.c b/cpus-common.c
> index 47f7c06..59c8dc8 100644
> --- a/cpus-common.c
> +++ b/cpus-common.c
> @@ -136,11 +136,6 @@ void async_run_on_cpu(CPUState *cpu, run_on_cpu_func
> func, void *data)
> {
> struct qemu_work_item *wi;
>
> - if (qemu_cpu_is_self(cpu)) {
> - func(cpu, data);
> - return;
> - }
> -
> wi = g_malloc0(sizeof(struct qemu_work_item));
> wi->func = func;
> wi->data = data;
Reviewed-by: Alex Bennée <address@hidden>
--
Alex Bennée
- [Qemu-devel] [PATCH 03/12] cpus: Rename flush_queued_work(), (continued)
- [Qemu-devel] [PATCH 03/12] cpus: Rename flush_queued_work(), Paolo Bonzini, 2016/09/01
- [Qemu-devel] [PATCH 07/12] cpus-common: move CPU work item management to common, Paolo Bonzini, 2016/09/01
- [Qemu-devel] [PATCH 06/12] cpus-common: move CPU list management to common code, Paolo Bonzini, 2016/09/01
- [Qemu-devel] [PATCH 12/12] cpus-common: lock-free fast path for cpu_exec_start/end, Paolo Bonzini, 2016/09/01
- [Qemu-devel] [PATCH 11/12] tcg: Make tb_flush() thread safe, Paolo Bonzini, 2016/09/01
- [Qemu-devel] [PATCH 09/12] cpus-common: always defer async_run_on_cpu work items, Paolo Bonzini, 2016/09/01
- Re: [Qemu-devel] [PATCH 09/12] cpus-common: always defer async_run_on_cpu work items,
Alex Bennée <=
- [Qemu-devel] [PATCH 10/12] cpus-common: Introduce async_safe_run_on_cpu(), Paolo Bonzini, 2016/09/01
- Re: [Qemu-devel] [PATCH 10/12] cpus-common: Introduce async_safe_run_on_cpu(), Pranith Kumar, 2016/09/12
- Re: [Qemu-devel] [PATCH v6 00/12] cpu-exec: Safe work in quiescent state, Alex Bennée, 2016/09/05