Re: [Qemu-devel] [PATCH v3] target-i386: present virtual L3 cache info for vcpus

[Longpeng (Mike)]

Hi Eduardo,

On 2016/9/6 2:53, Eduardo Habkost wrote:

> On Fri, Sep 02, 2016 at 10:22:55AM +0800, Longpeng(Mike) wrote:
> [...]
>> ---
>> Changes since v2:
>>   - add more useful commit mesage.
>>   - rename "compat-cache" to "l3-cache-shared".
> 
> What exactly "shared" means here? All the property does is to
> enable/disable the L3 cache, as its own description says:
> 
>>
>> +    /* Compatibility bits for old machine types.
>> +     * If true present virtual l3 cache for VM.
>> +     */
>> +    bool enable_l3_cache_shared;
>> +
> 
> Why not just "l3-cache" or "l3-cache-enabled"?
> 

I wanted to fix l1/l2's inconsistent bugs together originally, so I named it
"compat-cache". But later I thought it's too ugly to adding much l1/l2's
compatible macros, so I given up this idea. Instead, rename it to 
"l3-cache-shared".

Thanks for your good suggestion. I will choose "l3-cache-enabled" in the v5.

-- 
Regards,
Longpeng(Mike)