Re: [Qemu-devel] [PATCH] crypto: report enum strings instead of values in errors

[Markus Armbruster]

"Daniel P. Berrange" <address@hidden> writes:

> Several error messages print out the raw enum value, which
> is less than helpful to users, as these values are not
> documented, nor stable across QEMU releases. Switch to use
> the enum string instead.
>
> The nettle impl also had two typos where it said "algorithm"
> instead of "mode".

It doesn't just say "algorithm", it actually prints it:

        error_setg(errp, "Unsupported cipher algorithm %d",
                   cipher->alg);

> Signed-off-by: Daniel P. Berrange <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>