[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Checkpatch false positives
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] Checkpatch false positives |
Date: |
Tue, 06 Sep 2016 12:19:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini writes:
> On 06/09/2016 11:11, Lluís Vilanova wrote:
>> no-reply writes:
>>> Checking PATCH 1/6: hypertrace: Add documentation...
>>> ERROR: trailing whitespace
>>> #109: FILE: docs/hypertrace.txt:92:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #110: FILE: docs/hypertrace.txt:93:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #117: FILE: docs/hypertrace.txt:100:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #123: FILE: docs/hypertrace.txt:106:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #130: FILE: docs/hypertrace.txt:113:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #154: FILE: docs/hypertrace.txt:137:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #156: FILE: docs/hypertrace.txt:139:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #160: FILE: docs/hypertrace.txt:143:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #171: FILE: docs/hypertrace.txt:154:
>>> + $
>>
>>> ERROR: trailing whitespace
>>> #181: FILE: docs/hypertrace.txt:164:
>>> + $
>>
>>> total: 10 errors, 0 warnings, 236 lines checked
>>
>>> Your patch has style problems, please review. If any of these errors
>>> are false positives report them to the maintainer, see
>>> CHECKPATCH in MAINTAINERS.
>>
>> The errors above are false positives. AFAIR, in .txt files empty lines in
>> code
>> examples need 4 white spaces to let the wiki properly render them as a single
>> code example block.
> Right, can you make a patch for that? It should recognize exactly 4
> patches and only apply to .txt and .md files.
Ok. I won't properly check this only applies to lines where surrounding text is
4-column-indented, though, so it can have false negatives.
Cheers,
Lluis
- [Qemu-devel] [PATCH v2 2/6] hypertrace: Add tracing event "guest_hypertrace", (continued)
- [Qemu-devel] [PATCH v2 2/6] hypertrace: Add tracing event "guest_hypertrace", Lluís Vilanova, 2016/09/05
- [Qemu-devel] [PATCH v2 1/6] hypertrace: Add documentation, Lluís Vilanova, 2016/09/05
- [Qemu-devel] [PATCH v2 4/6] hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event, Lluís Vilanova, 2016/09/05
- [Qemu-devel] [PATCH v2 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event, Lluís Vilanova, 2016/09/05
- [Qemu-devel] [PATCH v2 5/6] hypertrace: Add guest-side user-level library, Lluís Vilanova, 2016/09/05
- [Qemu-devel] [PATCH v2 6/6] hypertrace: Add guest-side Linux module, Lluís Vilanova, 2016/09/05
- Re: [Qemu-devel] [PATCH v2 0/6] hypertrace: Lightweight guest-to-QEMU trace channel, no-reply, 2016/09/05