[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/26] tests: fix test-vmstate leaks
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PULL 06/26] tests: fix test-vmstate leaks |
Date: |
Tue, 6 Sep 2016 16:26:19 +0400 |
Spotted thanks to ASAN.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
tests/test-vmstate.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 41fd841..d8da26f 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -50,16 +50,20 @@ static QEMUFile *open_test_file(bool write)
{
int fd = dup(temp_fd);
QIOChannel *ioc;
+ QEMUFile *f;
+
lseek(fd, 0, SEEK_SET);
if (write) {
g_assert_cmpint(ftruncate(fd, 0), ==, 0);
}
ioc = QIO_CHANNEL(qio_channel_file_new_fd(fd));
if (write) {
- return qemu_fopen_channel_output(ioc);
+ f = qemu_fopen_channel_output(ioc);
} else {
- return qemu_fopen_channel_input(ioc);
+ f = qemu_fopen_channel_input(ioc);
}
+ object_unref(OBJECT(ioc));
+ return f;
}
#define SUCCESS(val) \
--
2.10.0
- [Qemu-devel] [PULL 00/26] Leak patches, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 02/26] glib-compat: add g_(s)list_free_full(), Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 01/26] tests: fix test-qga leaks, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 03/26] qga: free the whole blacklist, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 05/26] tests: fix test-cutils leaks, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 04/26] qga: free remaining leaking state, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 06/26] tests: fix test-vmstate leaks,
Marc-André Lureau <=
- [Qemu-devel] [PULL 07/26] tests: fix test-iov leaks, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 08/26] tests: fix check-qom-interface leaks, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 09/26] tests: fix check-qom-proplist leaks, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 10/26] tests: fix small leak in test-io-channel-command, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 11/26] tests: fix leak in test-string-input-visitor, Marc-André Lureau, 2016/09/06
- [Qemu-devel] [PULL 12/26] portio: keep references on portio, Marc-André Lureau, 2016/09/06