qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] tests: fix small leak in test-io-channel-com


From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH v3] tests: fix small leak in test-io-channel-command
Date: Tue, 6 Sep 2016 09:47:05 -0400 (EDT)

Hi

----- Original Message -----
> On Tue, Sep 06, 2016 at 05:36:37PM +0400, Marc-André Lureau wrote:
> > srcfifo && dstfifo must still be freed if socat is not present.
> > 
> > Only unlink if the fifo was actually created.
> > 
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> >  tests/test-io-channel-command.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> 
> I'll add this to my I/O queue unless you respin your current PULL request
> with this included.

I don't know what's best. Peter, should I send a new pull request with the new 
patch? Or send a new one without it? Or you can pull the current request 
without this patch?

thanks

> 
> Regards,
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]