[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/7] docker: debian-bootstrap.pre: print help
|
From: |
Sascha Silbe |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/7] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset |
|
Date: |
Tue, 06 Sep 2016 20:45:23 +0200 |
|
User-agent: |
Notmuch/0.22.1~rc0 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) |
Dear Fam,
Fam Zheng <address@hidden> writes:
[tests/docker/dockerfiles/debian-bootstrap.pre]
[...]
>> +if [ -z "${DEB_ARCH}" ]; then
>> + echo "Please set DEB_ARCH to choose an architecture (e.g. armhf)"
>> + exit_and_skip
>> +
>> +fi
>> +
>> +if [ -z "${DEB_TYPE}" ]; then
>> + echo "Please set DEB_TYPE to a Debian archive name (e.g. testing)"
>> + exit_and_skip
>> +
>
> Can you also update the three 'echo' commands to output the message to stderr?
I've updated my patch to send output to stderr and added a new patch
that fixes up the existing messages that are "fatal" (i.e. those
directly prior to an exit_and_skip).
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641