Re: [Qemu-devel] [PATCH v2 5/7] docker: make sure debootstrap is at least 1.0.67

[Sascha Silbe]

Dear Fam,

Fam Zheng <address@hidden> writes:

> On Wed, 08/24 20:31, Sascha Silbe wrote:
[tests/docker/dockerfiles/debian-bootstrap.pre]
>> +# debootstrap < 1.0.67 generates empty sources.list, see Debian#732255
>> +MIN_DEBOOTSTRAP_VERSION=1.0.67
[...]
>>  if [ -z $DEBOOTSTRAP_DIR ]; then
>> +    NEED_DEBOOTSTRAP=false
>>      DEBOOTSTRAP=`which debootstrap 2> /dev/null`
>>      if [ -z $DEBOOTSTRAP ]; then
>>          echo "No debootstrap installed, attempting to install from SCM"
>> +        NEED_DEBOOTSTRAP=true
>> +    elif ! (echo "${MIN_DEBOOTSTRAP_VERSION}" ; "${DEBOOTSTRAP}" --version 
>> |cut -d ' ' -f 2) |sort -VC; then
>
> Unbalanced whitespaces around '|'?

Sorry, habit from interactive shell usage. This way Ctrl+W will erase
the command and the pipe. Will fix this up.


> "sort -VC" seems to be unavalable on OSX. Is there another way to write the
> check?

Ah, right, BSD user space. sort -VC was such an elegant solution but
unfortunately it's a GNU extension. I'll try to come it up with some sed
or cut based hack instead.

Sascha
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641