Re: [Qemu-devel] [PATCH] tests/hd-geo-test: Don't pass NULL to unlink()

[John Snow]

On 09/06/2016 08:47 AM, Peter Maydell wrote:
> Ping?
>
> thanks
> -- PMM

Not sure who this belongs to; I can queue it up alongside some IDE and 
FDC stuff in the future if you like.

--js

> On 5 August 2016 at 11:03, Peter Maydell <address@hidden> wrote:
> > The unlink() function doesn't accept a NULL pointer, so
> > don't pass it one. Spotted by the clang sanitizer.
> >
> > Signed-off-by: Peter Maydell <address@hidden>
> > ---
> >  tests/hd-geo-test.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
> > index 12ee392..6176e81 100644
> > --- a/tests/hd-geo-test.c
> > +++ b/tests/hd-geo-test.c
> > @@ -416,7 +416,9 @@ int main(int argc, char **argv)
> >      ret = g_test_run();
> >
> >      for (i = 0; i < backend_last; i++) {
> > -        unlink(img_file_name[i]);
> > +        if (img_file_name[i]) {
> > +            unlink(img_file_name[i]);
> > +        }
> >      }
> >
> >      return ret;
> > --
> > 2.7.4

--
—js