[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906 |
Date: |
Wed, 07 Sep 2016 07:52:29 +1000 |
On Tue, 2016-09-06 at 23:09 +0200, Thomas Huth wrote:
> The bad commit is: "ppc: Speed up load/store multiple"
>
> There are two "#if defined(HOST_WORDS_BIGENDIAN)" sections in this patch
> which are both bad: The memcpy tries to copy 32-bit values into 64-bit
> registers, which of course does not work (unless you compile this code
> for a 32-bit host only where the size of a gpr is only 32-bit).
The instruction does that. It only copies 32-bits. I think it's
correct.
> I'd suggest to remove the "#if defined(HOST_WORDS_BIGENDIAN)" part and
> use cpu_to_be32() and friends instead of the bswap32() here?
I tried that but it prevents the faster memcpy, the whole point was to
speed things up...
Cheers,
Ben.
- [Qemu-devel] [PULL 21/66] ppc: Move VSX ops out of translate.c, (continued)
- [Qemu-devel] [PULL 21/66] ppc: Move VSX ops out of translate.c, David Gibson, 2016/09/05
- [Qemu-devel] [PULL 50/66] target-ppc: add vcmpnez[b, h, w][.] instructions, David Gibson, 2016/09/05
- [Qemu-devel] [PULL 56/66] hw/ppc: add a ppc_create_page_sizes_prop() helper routine, David Gibson, 2016/09/05
- [Qemu-devel] [PULL 62/66] ppc: Improve the exception helpers flags, David Gibson, 2016/09/05
- [Qemu-devel] [PULL 66/66] tests: Check serial output of firmware boot of some machines, David Gibson, 2016/09/05
- [Qemu-devel] [PULL 20/66] ppc: Move VMX ops out of translate.c, David Gibson, 2016/09/05
- [Qemu-devel] [PULL 18/66] ppc: Move embedded spe ops out of translate.c, David Gibson, 2016/09/05
- Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906, no-reply, 2016/09/06
- Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906, Peter Maydell, 2016/09/06
- Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906, Thomas Huth, 2016/09/06
[Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906, David Gibson, 2016/09/05