[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 4/8] docker: debian-bootstrap.pre: print helpful
From: |
Sascha Silbe |
Subject: |
[Qemu-devel] [PATCH v3 4/8] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset |
Date: |
Tue, 6 Sep 2016 22:05:47 +0200 |
The debian-bootstrap image doesn't choose a default architecture and
distribution version, instead the user has to set both DEB_ARCH and
DEB_TYPE in the environment. Print a reasonably helpful message if
either of them isn't set instead of complaining about "qemu-" being
missing or erroring out because we cannot cd to the mirror URL.
Signed-off-by: Sascha Silbe <address@hidden>
---
v2→v3:
- send error messages to stderr
tests/docker/dockerfiles/debian-bootstrap.pre | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre
b/tests/docker/dockerfiles/debian-bootstrap.pre
index 9b95a6b..3d9f7f4 100755
--- a/tests/docker/dockerfiles/debian-bootstrap.pre
+++ b/tests/docker/dockerfiles/debian-bootstrap.pre
@@ -15,6 +15,19 @@ exit_and_skip()
if [ -z $FAKEROOT ]; then
echo "Please install fakeroot to enable bootstraping" >&2
exit_and_skip
+
+fi
+
+if [ -z "${DEB_ARCH}" ]; then
+ echo "Please set DEB_ARCH to choose an architecture (e.g. armhf)" >&2
+ exit_and_skip
+
+fi
+
+if [ -z "${DEB_TYPE}" ]; then
+ echo "Please set DEB_TYPE to a Debian archive name (e.g. testing)" >&2
+ exit_and_skip
+
fi
# We check in order for
--
1.9.1
- [Qemu-devel] [PATCH v3 0/8] docker tests fixes, Sascha Silbe, 2016/09/06
- [Qemu-devel] [PATCH v3 1/8] docker.py: don't hang on large docker output, Sascha Silbe, 2016/09/06
- [Qemu-devel] [PATCH v3 7/8] docker: build debootstrap after cloning, Sascha Silbe, 2016/09/06
- [Qemu-devel] [PATCH v3 6/8] docker: make sure debootstrap is at least 1.0.67, Sascha Silbe, 2016/09/06
- [Qemu-devel] [PATCH v3 5/8] docker: print warning if EXECUTABLE is not set when building debootstrap image, Sascha Silbe, 2016/09/06
- [Qemu-devel] [PATCH v3 8/8] docker: silence debootstrap when --quiet is given, Sascha Silbe, 2016/09/06
- [Qemu-devel] [PATCH v3 3/8] docker: debian-bootstrap.pre: print error messages to stderr, Sascha Silbe, 2016/09/06
- [Qemu-devel] [PATCH v3 4/8] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset,
Sascha Silbe <=
- [Qemu-devel] [PATCH v3 2/8] docker: avoid dependency on 'realpath' package, Sascha Silbe, 2016/09/06
- Re: [Qemu-devel] [PATCH v3 0/8] docker tests fixes, Fam Zheng, 2016/09/08