[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 08/28] translate-all: Add assert_(memory|tb)_lo
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [RFC v4 08/28] translate-all: Add assert_(memory|tb)_lock annotations |
Date: |
Wed, 07 Sep 2016 08:08:25 +0100 |
User-agent: |
mu4e 0.9.17; emacs 25.1.11 |
Richard Henderson <address@hidden> writes:
> On 08/11/2016 08:24 AM, Alex Bennée wrote:
>> This adds calls to the assert_(memory|tb)_lock for all public APIs which
>> are documented as needing them held for linux-user mode. The asserts are
>> NOPs for system-mode although these will be converted when MTTCG is
>> enabled.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>> @@ -1111,7 +1121,7 @@ static void build_page_bitmap(PageDesc *p)
>> tb_end = tb_start + tb->size;
>> if (tb_end > TARGET_PAGE_SIZE) {
>> tb_end = TARGET_PAGE_SIZE;
>> - }
>> + }
>> } else {
>
> Introducing a whitespace error?
Oops, that sneaked in.
--
Alex Bennée