[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table |
|
Date: |
Thu, 8 Sep 2016 18:06:45 +0300 |
On Thu, Sep 08, 2016 at 07:56:38AM -0400, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
> > Regarding Patch 2/2:
> > This patch seems to filter responses from set_mem_table only for certain
> > updates of memory regions. It violates the definition of the REPLY_ACK
> > feature. This feature expects the client to send a response for every call
> > of set_mem_table. And here, qemu exits the set_mem_table() function in some
> > cases without even waiting for the reply that is going to come in.
> >
>
> Agreed with Prerna here,
>
> Furthermore, I haven't followed closely the recents developments, and the
> commit message doesn't explain why it should not be necessary to sync the
> first time set-mem-table is called. Could you develop that?
>
> thanks
Basically if we send set mem table when backend is not started,
there is no reason to wait for a response.
--
MST