[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/5] ipmi_bmc_sim: Remove an unnecessary mutex
From: |
minyard |
Subject: |
[Qemu-devel] [PATCH 2/5] ipmi_bmc_sim: Remove an unnecessary mutex |
Date: |
Thu, 8 Sep 2016 14:52:30 -0500 |
From: Corey Minyard <address@hidden>
Get rid of the unnecessary mutex, it was a vestige
of something else that was not done. That way we don't
have to free it.
Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
hw/ipmi/ipmi_bmc_sim.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 190e169..b38f4f0 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipmi_bmc_sim.c
@@ -217,7 +217,6 @@ struct IPMIBmcSim {
/* Odd netfns are for responses, so we only need the even ones. */
const IPMINetfn *netfns[MAX_NETFNS / 2];
- QemuMutex lock;
/* We allow one event in the buffer */
uint8_t evtbuf[16];
@@ -940,7 +939,6 @@ static void get_msg(IPMIBmcSim *ibs,
{
IPMIRcvBufEntry *msg;
- qemu_mutex_lock(&ibs->lock);
if (QTAILQ_EMPTY(&ibs->rcvbufs)) {
rsp_buffer_set_error(rsp, 0x80); /* Queue empty */
goto out;
@@ -960,7 +958,6 @@ static void get_msg(IPMIBmcSim *ibs,
}
out:
- qemu_mutex_unlock(&ibs->lock);
return;
}
@@ -1055,11 +1052,9 @@ static void send_msg(IPMIBmcSim *ibs,
end_msg:
msg->buf[msg->len] = ipmb_checksum(msg->buf, msg->len, 0);
msg->len++;
- qemu_mutex_lock(&ibs->lock);
QTAILQ_INSERT_TAIL(&ibs->rcvbufs, msg, entry);
ibs->msg_flags |= IPMI_BMC_MSG_FLAG_RCV_MSG_QUEUE;
k->set_atn(s, 1, attn_irq_enabled(ibs));
- qemu_mutex_unlock(&ibs->lock);
}
static void do_watchdog_reset(IPMIBmcSim *ibs)
@@ -1753,7 +1748,6 @@ static void ipmi_sim_realize(DeviceState *dev, Error
**errp)
unsigned int i;
IPMIBmcSim *ibs = IPMI_BMC_SIMULATOR(b);
- qemu_mutex_init(&ibs->lock);
QTAILQ_INIT(&ibs->rcvbufs);
ibs->bmc_global_enables = (1 << IPMI_BMC_EVENT_LOG_BIT);
--
2.7.4
- [Qemu-devel] [PATCH 0/5] ipmi: Minor fixes, minyard, 2016/09/08
- [Qemu-devel] [PATCH 2/5] ipmi_bmc_sim: Remove an unnecessary mutex,
minyard <=
- [Qemu-devel] [PATCH 4/5] ipmi: Implement shutdown via ACPI overtemp, minyard, 2016/09/08
- [Qemu-devel] [PATCH 3/5] ipmi: chassis poweroff should use qemu_system_shutdown_request(), minyard, 2016/09/08
- [Qemu-devel] [PATCH 1/5] ipmi: Remove hotplug from IPMI BMCs, minyard, 2016/09/08
- [Qemu-devel] [PATCH 5/5] ipmi: fix build config variable name for ipmi_bmc_extern.o, minyard, 2016/09/08
- [Qemu-devel] [PATCH] ipmi: Add graceful shutdown handling to the external BMC, minyard, 2016/09/12