qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw


From: Holger Schranz
Subject: Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices
Date: Fri, 9 Sep 2016 17:01:36 +0200
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

Hello Eric, Kevin, Paolo,

Thank you very much for the very fast help.

All works fine now!!!

Best regards and have nice weekend

Holger

Am 08.09.2016 um 19:34 schrieb Holger Schranz:
Hi Eric,

Am 08.09.2016 um 17:25 schrieb Eric Blake:
On 09/08/2016 09:27 AM, Holger Schranz wrote:
Hi Eric,

Thanks a lot, it seems the patch works. The VM starting.
Should I take that as a Tested-by: line?

The test was:
1) login as root
2) cd to workdir
3) start virt-viewer: "virt-viewer VCS82M3-IUP0 --wait &"
4) start VM with: "virsh create M3-IUP0.xml".

At the first test:
only an error message displayed (this was our first report) after execute the virsh command.

Last test (with your Patch V2).
Now, the virt-viewer shows the known dialog: BIOS ... System ... and closed
the session with error (megasas-issue)

Is this the information you wanted Eric?


Unfortunately we run into the next issue. By the accessing the
megasas controller we got a SIGSEGV.
Seems unrelated, let's figure out who's responsible.


/home/kvm/SOURCES/qemu.git/qemu/hw/scsi> diff megasas.c
/home/kvm/SOURCES/qemu-2.6.1/hw/scsi/megasas.c
'diff -u' is much easier to read than plain 'diff' (ed script diffs have
no context); in fact, 'git diff' uses -u format by default. Also, it's
traditional to 'diff old new', but you flipped the argument, so the diff
looks backwards.
O.k. . Thanks for the hint. We will use 'diff -u' in the future.

32c32
< #include "qapi/error.h"
---
51c51,55
     :
413a422,423
     return bcd_time;
1984c1994,1998
<         cmd->frame->header.cmd_status = frame_status;
---
         if (cmd->frame) {
             cmd->frame->header.cmd_status = frame_status;
         } else {
megasas_frame_set_cmd_status(s, frame_addr, frame_status);
         }
Here's a nicer way to get the above diff
$ git diff v2.6.1 v2.7.0 hw/scsi/megasas.c

at which point 'git gui blame hw/scsi/megasas.c' shows that it was
commit 8cc46787, by Paolo, that claimed that cmd->frame was non-NULL.



---
Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft.
https://www.avast.com/antivirus




---
Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft.
https://www.avast.com/antivirus




reply via email to

[Prev in Thread] Current Thread [Next in Thread]