qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 12/14] virtio-pci: minor refactoring


From: Michael S. Tsirkin
Subject: [Qemu-devel] [PULL 12/14] virtio-pci: minor refactoring
Date: Fri, 9 Sep 2016 23:34:30 +0300

!legacy && !modern is shorter than !(legacy || modern).
I also perfer this (less ()s) as a matter of taste.

Cc: Greg Kurz <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
 hw/virtio/virtio-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index d70c986..bf19808 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1776,7 +1776,7 @@ static void virtio_pci_realize(PCIDevice *pci_dev, Error 
**errp)
         proxy->disable_legacy = pcie_port ? ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF;
     }
 
-    if (!(virtio_pci_modern(proxy) || virtio_pci_legacy(proxy))) {
+    if (!virtio_pci_modern(proxy) && !virtio_pci_legacy(proxy)) {
         error_setg(errp, "device cannot work as neither modern nor legacy mode"
                    " is enabled");
         error_append_hint(errp, "Set either disable-modern or disable-legacy"
-- 
MST




reply via email to

[Prev in Thread] Current Thread [Next in Thread]